]> dgit.raspbian.org Git - gnome-shell.git/commit
messageTray: Avoid notification double destruction after activation
authorSebastian Keller <skeller@gnome.org>
Thu, 5 Mar 2026 12:04:37 +0000 (13:04 +0100)
committerSebastian Keller <skeller@gnome.org>
Thu, 5 Mar 2026 14:05:12 +0000 (15:05 +0100)
commit2fe0c2b4b23e526801ade3d54dedb578af04307c
treeff51eda839e1b6bb57dda456e7849fcd8419ea41
parent2326d8ee7b49db59b7ccaa0393b66f78075a6972
messageTray: Avoid notification double destruction after activation

The activation handler of a notification may indirectly have already
destroyed it before `activate()` continues and tries to destroy it.

This happened for example in the `FdoNotificationDaemon` activation
handler when no default actions are specified, which ends up calling
`destroyNonResidentNotifications()`.

Another case where this could happen is the `WindowAttentionHandler`
which activates the window and upon activation of the window destroys
the entire notification source, which also destroys the notification.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5421
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4113>
js/ui/messageTray.js